Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: variable scope in delete command #612

Merged

Conversation

vladdoster
Copy link
Member

@vladdoster vladdoster commented Dec 24, 2023

Description

zinit from'gh-r' for \
  sbin'fx*->fx'  @antonmedv/fx \
  sbin'bat->bat' @sharkdp/bat  \
  sbin'fd->fd'   @sharkdp/fd   \
  sbin'fogg'     @chanzuckerberg/fogg \
  sbin'gh->new-gh' @cli/cli \
  sbin'hugo->sbin_hugo' @gohugoio/hugo

Fixes issue in delete command causing incorrect values to be used when using for syntax.

before

Screenshot 2023-12-24 at 08 13 22

after

Screenshot 2023-12-24 at 08 16 10

Related Issue(s)

Closes zdharma-continuum/zinit-annex-bin-gem-node/issues/13

Motivation and Context

Usage examples

zinit from'gh-r' for \
  sbin'fx*->fx'  @antonmedv/fx \
  sbin'bat->bat' @sharkdp/bat  \
  sbin'fd->fd'   @sharkdp/fd   \
  sbin'fogg'     @chanzuckerberg/fogg \
  sbin'gh->new-gh' @cli/cli \
  sbin'hugo->sbin_hugo' @gohugoio/hugo

zi delete \
  antonmedv/fx \
  gohugoio/hugo \
  sharkdp/fd \
  sharkdp/bat \
  chanzuckerberg/fogg \
  cli/cli

How Has This Been Tested?

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation change
  • New feature (non-breaking change which adds functionality)

Checklist:

  • All new and existing tests passed.
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@vladdoster vladdoster closed this Dec 30, 2023
@vladdoster vladdoster reopened this Dec 30, 2023
@vladdoster vladdoster changed the base branch from main to refactor/make-ices December 30, 2023 01:50
@vladdoster vladdoster merged commit 72dee44 into zdharma-continuum:refactor/make-ices Dec 30, 2023
1 check passed
@vladdoster vladdoster deleted the fix/sbin-delete branch January 18, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Not automatically delete $ZPFX/bin files
1 participant