Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate -o xtrace when needed and prepend builtin to emulate #293

Merged
merged 1 commit into from
May 29, 2022

Conversation

psprint
Copy link
Contributor

@psprint psprint commented May 29, 2022

Description

The patch adds -o xtrace to all emulate -L calls when needed, i.e.: when already active at the entry to the function.

Motivation and Context

I've saw some GH issue where this problem, i.e.: of vanishing xtrace mode in emulate -L zsh functions was described.

Also, the patch adds builtin before all emulate calls.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@github-actions github-actions bot added the zinit label May 29, 2022
@vladdoster
Copy link
Member

vladdoster commented May 29, 2022

For brevity, could you link the issue you are referencing?

Is this the issue? It's the only issue that has a trace reference.

@psprint
Copy link
Contributor Author

psprint commented May 29, 2022

No it was a different issue. Someone elaborated on how difficult it is to xtrace zinit execution due to emulate -L zsh calls. I cannot find it, and I've also stumbled upon the issue you mentioned.

@vladdoster vladdoster merged commit bcedc9f into zdharma-continuum:main May 29, 2022
@jankatins
Copy link
Contributor

Wohoo, thanks!

@psprint
Copy link
Contributor Author

psprint commented Jun 1, 2022

The comment/PR that I was talking about is here.

@github-actions
Copy link

github-actions bot commented Nov 7, 2022

🎉 This PR is included in version 3.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants