Pedantic warning: Return != 0 when a hook fails

[pschmitt]

Fixes #111

This also logs an explicit warning when a hook fails:

Warning: ∞zinit-compile-plugin-hook hook returned with 1

[pschmitt]

Surprise, surprise: this makes the zunit tests fail ;)

There's still a bit more work to do here.

DO NOT MERGE

[pschmitt]

Okay, this was easier than I thought.

This is still a potentially breaking change, since it makes zinit quite a bit more strict in regards to return codes.

[alichtman]

This is still a potentially breaking change, since it makes zinit quite a bit more strict in regards to return codes.

I'm cool with a major version bump if this could change behavior of other programs. We've done some pretty heavy modification, so it's getting time for a major release anyways.

[pschmitt]

so it's getting time for a major release anyways.

Hence the v4.0 milestone :)

[alichtman]

[pschmitt]

This needs a dedicated ci check.

zinit null atclone'return 69' for zdharma-continuum/null

's RC should match 69 in zunit

[pschmitt]

Done (see the ices zunit test)

Also: I've forwarded the rc even further. You get the actual != 0 rc of the failing ice now instead of a static 1 when anything goes wrong.

[pschmitt]

Update: zinit update return the right rcs now

[pschmitt]

Forgot to mention: the atpull ice now has a dedicated zunit test and correctly forwards its rc to zinit

[pschmitt]

Okay, docs updated and all. This is ready IMO.
Any last words?

[fhilgers]

In zinit-install.zsh the Function zinit-mv-hook can never return 0 as one of

command mv -vf "${afr[1]}" "$to"
command mv -vf "${afr[1]}".zwc "$to".zwc 2>/dev/null

will always return 1.
So zinit always shows that an error happened on the mv-hook even though it ran successfully.

[pschmitt]

Thanks for the hint. Will fix that.

Edit: #126

[github-actions]

🎉 This PR is included in version 3.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀