A null dynamic value is a known value when comparing equality #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking for nested dynamic types within complex types for equality comparison, we need to also verify that those dynamic types are not already known to be null. Add the Value.HasDynamicValues method, to check for nested DynamicVal values. HasDynamicValues indicates not only that this value is unknown, but the type may change as well. This is used in the Value.Equals method before checking the type for equality.
Even when a value contains dynamic values, we may still be able to determine inequality when there is no way the types could conform.
alisdair
approved these changes
Jun 3, 2020
We weren't checking for unknown types within an unknown container.
HasDynamicTypes was not checking element collection types
This better describes the intent, and is a little more constant with the other Value method names.
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
+ Coverage 70.54% 70.73% +0.19%
==========================================
Files 79 79
Lines 7153 7176 +23
==========================================
+ Hits 5046 5076 +30
+ Misses 1664 1659 -5
+ Partials 443 441 -2
Continue to review full report at Codecov.
|
| // DynamicVal. This implies that both the value is not known, and the final | ||
| // type may change. | ||
| func (val Value) HasDynamicValues() bool { | ||
| func (val Value) HasWhollyKnownType() bool { |
There was a problem hiding this comment.
It looks like you inverted the direction of the name here but not the implementation along with it... if I'm reading correctly, the logic below seems to produce an answer to "Doesn't have a wholly known type".
There was a problem hiding this comment.
😆 oh yes, I just did a find and replace 😞 Will fix ASAP
The name was updated, but the actual logic was not inverted to match the new name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking for nested dynamic types within complex types for equality comparison, we need to also verify that those dynamic types are not already known to be null.
Add the
Value.HasWhollyKnownTypemethod, to check for nestedDynamicValvalues.HasWhollyKnownTypeindicates not only that this value is not wholly known, but the type may change as well; as opposed toHasDynamicTypes, which only indicates thatDynamicPseudoTypeexists within the type. This is used in theValue.Equalsmethod before checking the type for equality.Even when a value contains
DynamicVal, we may still be able to check for inequality if the types are not conformant. CheckTestConformancein both directions to see if there is any possibility of the types later becoming equal.This also fixes a bug in
Type.HasDynamicTypes, which was failing to descent into container element types.