function/stdlib: jsonencode should produce a string representation of…

… null
zclconf · May 28, 2020 · e76fe06 · e76fe06
1 parent 6e20bc2
commit e76fe06
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/cty/function/stdlib/json.go b/cty/function/stdlib/json.go
@@ -12,6 +12,7 @@ var JSONEncodeFunc = function.New(&function.Spec{
 			Name:             "val",
 			Type:             cty.DynamicPseudoType,
 			AllowDynamicType: true,
+			AllowNull:        true,
 		},
 	},
 	Type: function.StaticReturnType(cty.String),
@@ -24,6 +25,10 @@ var JSONEncodeFunc = function.New(&function.Spec{
 			return cty.UnknownVal(retType), nil
 		}
 
+		if val.IsNull() {
+			return cty.StringVal("null"), nil
+		}
+
 		buf, err := json.Marshal(val, val.Type())
 		if err != nil {
 			return cty.NilVal, err

diff --git a/cty/function/stdlib/json_test.go b/cty/function/stdlib/json_test.go
@@ -52,6 +52,10 @@ func TestJSONEncode(t *testing.T) {
 			cty.DynamicVal,
 			cty.UnknownVal(cty.String),
 		},
+		{
+			cty.NullVal(cty.String),
+			cty.StringVal("null"),
+		},
 	}
 
 	for _, test := range tests {