ZIP 32: Define an arbitrary key derivation process#908
Merged
Conversation
daira
reviewed
Oct 1, 2024
daira
reviewed
Oct 1, 2024
daira
reviewed
Oct 1, 2024
Collaborator
Author
|
Force-pushed to add missing BCP 14 keywords and re-render. |
daira
reviewed
Oct 1, 2024
Collaborator
There was a problem hiding this comment.
This needs to be included in https://zips.z.cash/protocol/protocol.pdf#abstractprfs, but not necessarily in this PR.
daira
approved these changes
Oct 1, 2024
Co-authored-by: Daira-Emma Hopwood <daira@jacaranda.org>
daira
approved these changes
Oct 3, 2024
Collaborator
|
Oops, this required ZIP Editor review. Sorry about that, I've been used to just merging. (I should probably adjust my permissions on zcash/zips to not be able to do that so easily.) |
vivek-arte
added a commit
to QED-it/zips
that referenced
this pull request
Oct 8, 2024
This makes the changes to align with the change in notation for ZIP 32 done in zcash#908.
conradoplg
reviewed
Oct 9, 2024
Comment on lines
+378
to
+379
| derivation. This should be tracked as part of the global set of domains defined for | ||
| :math:`\mathsf{PRF^{expand}}`. |
Collaborator
There was a problem hiding this comment.
add reference to spec (section 4.1.2)
conradoplg
reviewed
Oct 9, 2024
Collaborator
conradoplg
left a comment
conradoplg
left a comment
There was a problem hiding this comment.
Reviewed post-merge by @nuttycom @arya2 @conradoplg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hardened-only key derivation process from Orchard key derivation is extracted for reuse.