Conversation
This was missed in the refactor PR.
There was a problem hiding this comment.
I'm almost sure that this won't work. GitHub pages will only serve a static site. The sites that use Jinja have a GitHub Action that renders the template to HTML; here you're trying to include the template in the HTML.
I think this will work:
| --- | |
| redirect_to: "https://zips.z.cash/zip-2001" | |
| --- | |
| <!DOCTYPE html> | |
| <html> | |
| <head> | |
| <title>ZIP 2001: Lockbox Funding Streams (redirect)</title> | |
| <meta http-equiv="refresh" content="0; https://zips.z.cash/zip-2001"> | |
| </head> | |
| </html> |
There was a problem hiding this comment.
It was unclear to me how GitHub Pages Jinja was configured. The existence of _config.yml in the repo implied that you were already using it, and AFAICT the way you configure Jinja for a given page is to prepend YML to the HTML.
That being said, indeed this particular gem is intended to generate the equivalent of the HTML you've given, so if the Jinja stuff doesn't work, then we should a) use your suggestion, and b) delete _config.yml to stop it being misleading.
There was a problem hiding this comment.
I think _config.yml is probably a leftover, but I could be wrong.
There was a problem hiding this comment.
We will find out one way or another once this PR merges.
There was a problem hiding this comment.
This is unnecessary (and will not work). It would only have an effect when rendering the HTML; see my other comment.
| gems: | |
| - jekyll-redirect-from |
There was a problem hiding this comment.
If this doesn't work, then the entire _config.yml is doing nothing, because that config file is for Jinja.
There was a problem hiding this comment.
https://github.com/orgs/community/discussions/53549 seems to indicate that Jinja is always running because GitHub Pages is powered by it, which would imply that gems do work.
daira
left a comment
daira
left a comment
There was a problem hiding this comment.
Changes needed. In particular I'm almost sure the redirect won't work, and I have suggested an alternative.
|
Force-pushed to address @daira's comments. |
|
Post-hoc ACK |
2 participants
Also attempts to add a redirect from the old URL to the new one. We won't know if this worked until this PR is merged.