Fix errors in protocol and ZIPs#702
Merged
Merged
Conversation
This was likely a copy-paste error with the section above it, which is very similar but presents the human-readable part of *incoming* viewing keys.
The `LEBS2OS` function does not exist and isn't meant to. This reference is understood to have meant `LEBS2OSP`. See discussion at: https://forum.zcashcommunity.com/t/what-is-the-lebs2os-function-in-the-zip-32-spec/44886
The `dk` value is 256 bits long. It's the *diversifier* that is only 88 bits long. The incoming viewing key requires the diversifier key -- not the diversifier. This change also reflects the de facto standard in implementations up to this point, including YWallet and the [zcash_address crate](https://docs.rs/zcash_address/latest/src/zcash_address/kind/unified/ivk.rs.html).
AArnott
commented
Jul 31, 2023
daira
reviewed
Aug 22, 2023
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"character at the end of a URI example.dkThe
dkvalue is 256 bits long. It's the diversifier that is only 88 bits long. The incoming viewing key requires the diversifier key -- not the diversifier.This change also reflects the de facto standard in implementations up to this point, including YWallet and the zcash_address crate.
Fix reference to undefined LEBS2OS function
The
LEBS2OSfunction does not exist and isn't meant to. This reference is understood to have meantLEBS2OSP.See discussion at:
https://forum.zcashcommunity.com/t/what-is-the-lebs2os-function-in-the-zip-32-spec/44886
This was likely a copy-paste error with the section above it, which is very similar but presents the human-readable part of incoming viewing keys.