-
Notifications
You must be signed in to change notification settings - Fork 179
ZIP 302: Structured memos #638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
str4d
wants to merge
5
commits into
main
Choose a base branch
from
zip302-structured-memos
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3b0d65e
ZIP 302: Initial draft of Structured Memos
str4d 1c3db81
ZIP 302: Specify `partType` using decimal instead of hex
str4d c38a07b
ZIP 302: Add version field to structured memos
str4d 369dba1
ZIP 302: Specify memo part types for private use and experimentation
str4d 82fe03d
ZIP 302: Update URL for the reference to ZIP 231.
daira File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In ZIP Sync, we decided to require that the parser default to "unknown-reject": if a
partTypeis unknown, error and do not return any understood part types to the wallet. We will then define that anypartTypein the range30000-65535is "optional" and can be stored in anUnknownhandler (and then move the "assigned private use" section to the start of this range).