Specify precisely the data to be signed#23
Merged
Conversation
to use a single signature covering all of the transaction except pourPubKey and pubSig. Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Collaborator
|
ephemeralKey in your table describing the contents of a PourTx needs to be magenta. Also, pourSig/pourPubKey should be specific to the pour because the pours may be created by different people. |
Collaborator
|
Besides flexibility, it's also nice that |
Collaborator
Author
|
We decided to use the single-signature approach that is in the current spec. |
daira
pushed a commit
to daira/zips
that referenced
this pull request
Nov 8, 2023
As per the title, this is a tiny fix to adjust the boundary of the math environment which wasn't properly closed and thus rendered poorly on the html.
daira
pushed a commit
to daira/zips
that referenced
this pull request
Feb 7, 2024
As per the title, this is a tiny fix to adjust the boundary of the math environment which wasn't properly closed and thus rendered poorly on the html.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes a design change to use a single signature covering all of the transaction except pourPubKey and pubSig.
Signed-off-by: Daira Hopwood daira@jacaranda.org