[ZIP 246] Updating orchard_auth_digest details to avoid nested loops#1095
Merged
nuttycom merged 5 commits intoSep 30, 2025
Merged
Conversation
daira
reviewed
Sep 30, 2025
daira
reviewed
Sep 30, 2025
daira
reviewed
Sep 30, 2025
Co-authored-by: Daira-Emma Hopwood <daira@jacaranda.org>
vivek-arte
commented
Sep 30, 2025
nuttycom
reviewed
Sep 30, 2025
daira
reviewed
Sep 30, 2025
PaulLaux
pushed a commit
to QED-it/orchard
that referenced
this pull request
Oct 1, 2025
Update orchard_auth_digest according to [zips PR 1095](zcash/zips#1095)
ConstanceBeguier
added a commit
to QED-it/librustzcash
that referenced
this pull request
Oct 2, 2025
In Orchard repo commit abd6ecc, we added spend_auth_sigs_auth_digest into orchard_auth_digest according to [zips PR 1095](zcash/zips#1095). To take into account this modification in librustzcash repo, we have to update the orchard_zsa_digests test vectors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing specification happened to contain a nested for loop in the
orchard_action_groups_auth_digest.This PR makes a change to remove this nesting via an additional digest, viz the
orchard_zsa_spend_auth_sigs_auth_digestto aggregate the spend authorization signatures from each Action in the Action Group into its own digest.