[ZIP 227, ZIP 230] Update of issuance validating key (ik) to issuer identifier (issuer)#1048
[ZIP 227, ZIP 230] Update of issuance validating key (ik) to issuer identifier (issuer)#10486 commits merged intozcash:mainfrom
ik) to issuer identifier (issuer)#1048Conversation
This PR updates the diagram of the relation between the issuance validating key, asset description and asset identifier to correctly describe the changes made in zcash#1042. It also responds to two comments that were added post the merge of that PR.
… to `issuer`, and renaming it to "issuer identifier" (#114) This PR makes the changes mentioned in ZIP 227, ZIP 230, and the relevant image files.
zips/zip-0227.rst
Outdated
|
|
||
| * $\mathsf{ik} := \mathtt{0x00} || \textit{PubKey}(\mathsf{isk})$ | ||
| * Return $\bot$ if the $\textit{PubKey}$ algorithm invocation fails, otherwise return $\mathsf{ik}$. | ||
| * $\mathsf{issuer} := \mathtt{0x00} || \textit{PubKey}(\mathsf{isk})$ |
There was a problem hiding this comment.
| * $\mathsf{issuer} := \mathtt{0x00} || \textit{PubKey}(\mathsf{isk})$ | |
| * $\mathsf{issuer} := \mathsf{ik} := \mathtt{0x00} || \textit{PubKey}(\mathsf{isk})$ |
There was a problem hiding this comment.
Done slightly differently, in QED-it#116.
There was a problem hiding this comment.
Update: The above PR is merged and the changes are now in this branch.
zips/zip-0227.rst
Outdated
| * $\mathsf{ik} := \mathtt{0x00} || \textit{PubKey}(\mathsf{isk})$ | ||
| * Return $\bot$ if the $\textit{PubKey}$ algorithm invocation fails, otherwise return $\mathsf{ik}$. | ||
| * $\mathsf{issuer} := \mathtt{0x00} || \textit{PubKey}(\mathsf{isk})$ | ||
| * Return $\bot$ if the $\textit{PubKey}$ algorithm invocation fails, otherwise return $\mathsf{issuer}$. |
There was a problem hiding this comment.
| * Return $\bot$ if the $\textit{PubKey}$ algorithm invocation fails, otherwise return $\mathsf{issuer}$. | |
| * Return $\bot$ if the $\textit{PubKey}$ algorithm invocation fails, otherwise return $\mathsf{ik}$, which is also the issuer identifier $\mathsf{issuer}$. |
There was a problem hiding this comment.
As above, done slightly differently in QED-it#116.
There was a problem hiding this comment.
Update: The above PR is merged and the changes are now in this branch.
daira
left a comment
daira
left a comment
There was a problem hiding this comment.
Reviewed with @arya2, @SamHSmith, and Andrew Reese in today's ZIP sync. Changes requested.
zips/zip-0227.rst
Outdated
|
|
||
|
|
||
| Define $\mathsf{IssueAuthSig.Validate} \;{\small ⦂}\; (\mathsf{ik} \;{\small ⦂}\; \mathsf{IssueAuthSig.Public}) \times (M \;{\small ⦂}\; \mathsf{IssueAuthSig.Message}) \times (\text{σ} \;{\small ⦂}\; \mathsf{IssueAuthSig.Signature}) \to \mathbb{B}$ as: | ||
| Define $\mathsf{IssueAuthSig.Validate} \;{\small ⦂}\; (\mathsf{issuer} \;{\small ⦂}\; \mathsf{IssueAuthSig.Public}) \times (M \;{\small ⦂}\; \mathsf{IssueAuthSig.Message}) \times (\text{σ} \;{\small ⦂}\; \mathsf{IssueAuthSig.Signature}) \to \mathbb{B}$ as: |
There was a problem hiding this comment.
This should be using
There was a problem hiding this comment.
Update: The above PR is merged and the changes are now in this branch.
zips/zip-0227.rst
Outdated
|
|
||
| * Return $0$ if $\text{σ} = \bot$. | ||
| * Parse $\text{σ}$ as $\mathtt{0x00} || \mathsf{sig}$ and parse $\mathsf{ik}$ as $\mathtt{0x00} || \mathsf{key}$. Return $0$ if the parsing fails. | ||
| * Parse $\text{σ}$ as $\mathtt{0x00} || \mathsf{sig}$ and parse $\mathsf{issuer}$ as $\mathtt{0x00} || \mathsf{key}$. Return $0$ if the parsing fails. |
There was a problem hiding this comment.
Using
There was a problem hiding this comment.
Update: The above PR is merged and the changes are now in this branch.
|
Why a separate PR QED-it#116 ? It would be easier to review that all the relevant changes have been made if they were added to this PR. |
This PR makes the changes requested in zcash#1048.
This PR makes updates to ZIP 246 (aka the V6 SIGHASH algorithm) based on the changes being made as a part of zcash#1048. A minor broken link is also fixed.
|
I made the changes internally in QED-it#116 so that we could review anything I missed before pushing to this PR. That's been done and the PR has been merged to this branch, so the requested changes can be reviewed here now. |
…es (#182) This PR makes the updates to the encoding of the issuance validating key and the issuance authorization signature, as done in the specification in zcash/zips#1042, along with the further updates in zcash/zips#1048 and zcash/zips#1053. The test vectors are updated in QED-it/zcash-test-vectors#31. --------- Co-authored-by: Constance Beguier <constance@qed-it.com>
3 participants
This PR makes the changes in ZIP 227 and ZIP 230 to rename the issuance validating key (
ik) as the issuer identifier (issuer).The motivation for this is to make the terms clearer in case of a future addition of key rotation to the issuance of ZSAs -- in which case the current key for issuance validation might not be the original key that identifies the issuer and connects it to the Asset Identifier.
The PR also includes changes to the corresponding image files for the diagrams that have been affected.
It also addresses the comments made by @daira here and here for greater clarity in the encodings of the issuer identifier and issuance authorization signature encodings.