Add generalization to support OrchardZSA and AssetBase#6
Merged
Conversation
Co-authored-by: Dmitry Demin <dmitry@qed-it.com>
daira
reviewed
Jan 22, 2025
|
|
||
| ## [Unreleased] | ||
| ### Changed | ||
| - **Breaking change:** removed the constants `COMPACT_NOTE_SIZE`, |
Contributor
Author
There was a problem hiding this comment.
I was going to address all of this in a subsequent PR after getting #2 in, but I guess now that I've been forced to open a separate PR for just that, I can fix the changelog at the same time.
Contributor
Author
There was a problem hiding this comment.
Eh, actually I will still do the changelog rework in a separate PR.
daira
reviewed
Jan 22, 2025
daira
reviewed
Jan 22, 2025
| abstract types `NotePlaintextBytes`, `NoteCiphertextBytes`, | ||
| `CompactNotePlaintextBytes`, and `CompactNoteCiphertextBytes` to the `Domain` | ||
| trait. | ||
| - Removed the separate `NotePlaintextBytes` type definition (as it is now an |
daira
reviewed
Jan 22, 2025
| array. | ||
| - Updated the `enc_ciphertext` method of the `ShieldedOutput` trait to return an | ||
| `Option` of a reference instead of a copy. | ||
| - Added a new `note_bytes` module with helper trait and struct to deal with note |
daira
reviewed
Jan 22, 2025
daira
reviewed
Jan 22, 2025
daira
reviewed
Jan 22, 2025
daira
reviewed
Jan 22, 2025
daira
reviewed
Jan 22, 2025
daira
reviewed
Jan 22, 2025
| pub trait NoteBytes: AsRef<[u8]> + AsMut<[u8]> + Clone + Copy { | ||
| fn from_slice(bytes: &[u8]) -> Option<Self>; | ||
|
|
||
| fn from_slice_with_tag<const TAG_SIZE: usize>( |
Co-authored-by: Daira-Emma Hopwood <daira@jacaranda.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase of #2.