Conversation
…rate, not `zcash_primitives`. fixes #7 Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
This exposes the `ExtractedCommitment` of the shielded output directly, in addition to the byte encoding exposed by `ShieldedOutput::cmstar_bytes`. This is useful for further generalizing scanning code that constructs note commitment tree leaves as part of its operation, allowing the `Domain` bound to provide the necessary type information for conversion into those leaf types.
nuttycom
force-pushed
the
feature/shielded_output_cmstar
branch
from
8958425 to
f32f895
Compare
nuttycom
force-pushed
the
feature/shielded_output_cmstar
branch
from
eb0eaaf to
84e094c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is useful to be able to obtain the parsed cmstar value in scanning, where this allows the
Domain::ExtractedNoteCommitmenttype to inform the creation of wallet-specific note commitment tree leaf types.