Skip to content

Add ZIP 320 test vectors.#97

Merged
nuttycom merged 2 commits into
zcash:masterfrom
nuttycom:zip_0320
Apr 24, 2024
Merged

Add ZIP 320 test vectors.#97
nuttycom merged 2 commits into
zcash:masterfrom
nuttycom:zip_0320

Conversation

@nuttycom
Copy link
Copy Markdown
Contributor

No description provided.

@nuttycom nuttycom force-pushed the zip_0320 branch 2 times, most recently from d0bf581 to 751c08e Compare April 22, 2024 02:32
Comment thread pyproject.toml Outdated
Comment thread test-vectors/json/zip_0320.json Outdated
Comment thread zcash_test_vectors/transparent/zip_0320.py Outdated
Comment thread zcash_test_vectors/zip_0320.py Outdated
Copy link
Copy Markdown
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes needed.

@nuttycom nuttycom force-pushed the zip_0320 branch 4 times, most recently from e1402cb to 5e51ec0 Compare April 23, 2024 18:49
@nuttycom
Copy link
Copy Markdown
Contributor Author

force-pushed to address comments from code review.

@nuttycom nuttycom requested a review from daira April 23, 2024 19:02
Comment thread test-vectors/json/zip_0320.json Outdated
Copy link
Copy Markdown
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK modulo the still-incorrect URLs.

Copy link
Copy Markdown
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@nuttycom nuttycom merged commit 2badeda into zcash:master Apr 24, 2024
@nuttycom nuttycom deleted the zip_0320 branch April 24, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants