Skip to content

Addition of pub(crate) visibility and other formatting updates#114

Merged
oxarbitrage merged 3 commits into
zcash:masterfrom
QED-it:formatting_updates_2
Apr 1, 2026
Merged

Addition of pub(crate) visibility and other formatting updates#114
oxarbitrage merged 3 commits into
zcash:masterfrom
QED-it:formatting_updates_2

Conversation

@vivek-arte
Copy link
Copy Markdown
Contributor

This PR makes further updates to the Rust test vectors to make it possible to copy paste the vectors directly into the places they are used.

It adds the pub (crate) visibility to the test vector struct and adjusts the indentation of the vectors to match usage in the repositories.

Copy link
Copy Markdown
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to tv_rust() in output.py look good. Verified that running bash regenerate.sh rust all with the PR's output.py produces the files committed in this PR. Also confirmed the generated files compile correctly as Rust modules with the expected pub(crate) visibility and indentation.

The two additional changes are minor:

  • zcash_test_vectors/orchard/note.py: removes an unused Scalar import.
  • pyproject.toml: alphabetical reordering of two script entries.

Merge order note: This PR should be merged before #112, since #112's rustfmt pass should be applied on top of these generator changes. Once this is merged, #112 will need to be rebased.

@oxarbitrage
Copy link
Copy Markdown
Contributor

oxarbitrage commented Mar 29, 2026

@vivek-arte can you rebase this onto main? PR #115 (Poetry → uv migration) landed since your last push, and I want to make sure CI passes with the new build system before merging. Once this is in, we can rebase and merge #112.

@vivek-arte vivek-arte force-pushed the formatting_updates_2 branch from 0825a15 to 0b57d62 Compare April 1, 2026 07:25
@vivek-arte
Copy link
Copy Markdown
Contributor Author

@oxarbitrage I rebased it, the CI works successfully on our local PR (QED-it#42) but the run needs to be approved on this repository.

@oxarbitrage oxarbitrage merged commit 43ecf41 into zcash:master Apr 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants