Skip to content

Update to latest zcash dependencies#35

Merged
str4d merged 2 commits into
zcash:mainfrom
nuttycom:update_librustzcash
Aug 20, 2024
Merged

Update to latest zcash dependencies#35
str4d merged 2 commits into
zcash:mainfrom
nuttycom:update_librustzcash

Conversation

@nuttycom
Copy link
Copy Markdown
Collaborator

No description provided.

str4d
str4d previously requested changes Aug 16, 2024
Copy link
Copy Markdown
Collaborator

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 82affa36a58c0242dc207d18f8adfd0ab630cffb

Comment thread src/commands/enhance.rs Outdated
Comment thread src/commands/enhance.rs Outdated
Comment thread src/commands/enhance.rs Outdated
Comment thread src/commands/enhance.rs Outdated
@str4d str4d dismissed their stale review August 16, 2024 16:37

Dismissing so I don't block subsequent ACKs from others if I am not online to re-review.

@nuttycom nuttycom requested a review from str4d August 16, 2024 17:44
@nuttycom nuttycom changed the title Update to librustzcash version 3b742843ab9c320dd2b01aa61552c6745fd4c4f Update to librustzcash version 7f7b685b99132505a0fe4ba588f329e3516e9669 Aug 16, 2024
Copy link
Copy Markdown
Collaborator

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 73160639d46c5482fbb19c7b5dc64de6df072d08 after PR title is fixed. Bug is non-blocking because it just causes overlap.

Comment thread Cargo.toml Outdated
Comment thread src/commands/enhance.rs Outdated
- `sapling-crypto 0.2`
- `orchard 0.9`
- `zcash_address 0.4`
- `zcash_client_backend 0.13`
- `zcash_client_sqlite 0.11`
- `zcash_keys 0.3`
- `zcash_primitives 0.16`
- `zcash_proofs 0.16`
- `zcash_protocol 0.2`
- `zip321 = `0.1`
@nuttycom nuttycom changed the title Update to librustzcash version 7f7b685b99132505a0fe4ba588f329e3516e9669 Update to latest zcash dependencies Aug 20, 2024
Copy link
Copy Markdown
Collaborator

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 2b2e435

@str4d str4d merged commit d11a653 into zcash:main Aug 20, 2024
@str4d str4d deleted the update_librustzcash branch August 20, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants