Skip to content

Connect to non-local lightwalletd over Tor for everything except sync#31

Merged
nuttycom merged 3 commits into
mainfrom
tor-lightwalletd
Aug 20, 2024
Merged

Connect to non-local lightwalletd over Tor for everything except sync#31
nuttycom merged 3 commits into
mainfrom
tor-lightwalletd

Conversation

@str4d
Copy link
Copy Markdown
Collaborator

@str4d str4d commented Jul 30, 2024

Copy link
Copy Markdown
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@daira
Copy link
Copy Markdown
Contributor

daira commented Jul 30, 2024

Does this close zcash/librustzcash#1471 ? Wrong repo. zcash/librustzcash#1472 closes zcash/librustzcash#1471.

@str4d
Copy link
Copy Markdown
Collaborator Author

str4d commented Jul 31, 2024

This is now conflicted with main due to #32 merging (which adds another lightwalletd call that needs migrating). I'll rebase on main once zcash/librustzcash#1472 is reviewed and merged.

str4d added 3 commits August 20, 2024 18:42
Most commands are single-shot, only making a couple of correlated
requests to the server. Enhancement makes requests that could be made
uncorrelated; that is left as a TODO.

Syncing currently requires a long-running connection, so we don't
migrate it yet.
@str4d str4d force-pushed the tor-lightwalletd branch from 8473f1e to d3e51e0 Compare August 20, 2024 18:49
@str4d
Copy link
Copy Markdown
Collaborator Author

str4d commented Aug 20, 2024

Rebased on main after crate releases that included the necessary API.

Copy link
Copy Markdown
Collaborator

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK d3e51e0

@nuttycom nuttycom merged commit 8c2e49f into main Aug 20, 2024
@nuttycom nuttycom deleted the tor-lightwalletd branch August 20, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants