Skip to content

Bugfix/improve incremental build#2

Merged
gmale merged 4 commits into
scan-blocksfrom
bugfix/improve-incremental-build
Nov 28, 2018
Merged

Bugfix/improve incremental build#2
gmale merged 4 commits into
scan-blocksfrom
bugfix/improve-incremental-build

Conversation

@gmale

@gmale gmale commented Nov 28, 2018

Copy link
Copy Markdown
Contributor

No description provided.

Copies where happening before the creation of the libraries.
previous version did a bad job of recognizing an incorrect config file. This makes it a bit better.
@gmale

gmale commented Nov 28, 2018

Copy link
Copy Markdown
Contributor Author

Merging to minimize branching of active development.

@gmale gmale merged commit 7bc732a into scan-blocks Nov 28, 2018
@gmale gmale deleted the bugfix/improve-incremental-build branch November 28, 2018 05:27
Comment thread .cargo/config
@@ -1,2 +1,17 @@
#auto-generated by build-ndk-standalone.sh. Modifications will get replaced.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This auto-generated file should have been removed from the repository.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll probably rebase the scan-blocks branch at some point, and I'll remove it then.

@lindanlee lindanlee mentioned this pull request Mar 3, 2020
2 tasks
HonzaR added a commit that referenced this pull request Jun 17, 2022
HonzaR added a commit that referenced this pull request Jul 21, 2022
- NoBackupContextWrapper now works with parent directory and database file separately, and thus does not violate Room API and should be more solid.
- Changed RustBackend parameters from String paths to Files.
- Fixed or disabled not working tests for SDK. Tests in ChangeServiceTest use java.util.Optional, so they've been disabled for Android SDK 23 and lower.
greg0x added a commit that referenced this pull request May 11, 2026
Addresses PR #1938 review comment #2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants