Migrate from yanked core2 library to corez#482
Merged
Conversation
nuttycom
force-pushed
the
corez_migration
branch
from
fb11341 to
e94ade8
Compare
nuttycom
force-pushed
the
corez_migration
branch
from
e94ade8 to
872a219
Compare
nullcopy
approved these changes
Apr 17, 2026
czarcas7ic
reviewed
Apr 17, 2026
|
|
||
| # No-std support | ||
| core2 = { version = "0.3", default-features = false, features = ["alloc"] } | ||
| corez = { version = "0.1.1", default-features = false, features = ["alloc"] } |
Collaborator
There was a problem hiding this comment.
I checked to see if corez 0.1.1 was a 1:1 match of the yanked core2 0.3, but it seems to be a slimmed down version. I checked the diff and the things that were removed appear safe to me.
Contributor
Author
There was a problem hiding this comment.
Correct; in particular, some code paths that could result in UB were removed; this is the minimal API surface that our crates actually need.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.