Upgrade patch version of halo2 dependencies.#382
Merged
nuttycom merged 2 commits intozcash:mainfrom Mar 20, 2023
Merged
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #382 +/- ##
=======================================
Coverage 83.43% 83.43%
=======================================
Files 32 32
Lines 2692 2692
=======================================
Hits 2246 2246
Misses 446 446 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
nuttycom
force-pushed
the
upgrade_halo2_patch_dependency
branch
from
ca54c18 to
16a143c
Compare
daira
reviewed
Mar 20, 2023
| halo2_gadgets = { git = "https://github.com/zcash/halo2.git", rev = "35eb268e202d76721abde3d6e50e719ae9140605" } | ||
| halo2_proofs = { git = "https://github.com/zcash/halo2.git", rev = "35eb268e202d76721abde3d6e50e719ae9140605" } | ||
| halo2_gadgets = { git = "https://github.com/zcash/halo2.git", rev = "642924d614305d882cc122739c59144109f4bd3f" } | ||
| halo2_proofs = { git = "https://github.com/zcash/halo2.git", rev = "642924d614305d882cc122739c59144109f4bd3f" } |
Contributor
There was a problem hiding this comment.
This is the correct hash (for now): zcash/halo2@642924d
sellout
approved these changes
Mar 20, 2023
| halo2_gadgets = { git = "https://github.com/zcash/halo2.git", rev = "35eb268e202d76721abde3d6e50e719ae9140605" } | ||
| halo2_proofs = { git = "https://github.com/zcash/halo2.git", rev = "35eb268e202d76721abde3d6e50e719ae9140605" } | ||
| halo2_gadgets = { git = "https://github.com/zcash/halo2.git", rev = "642924d614305d882cc122739c59144109f4bd3f" } | ||
| halo2_proofs = { git = "https://github.com/zcash/halo2.git", rev = "642924d614305d882cc122739c59144109f4bd3f" } |
Co-authored-by: Greg Pfeil <greg@technomadic.org>
Update to make use of the floor-planner-v1-legacy-pdqsort feature.
nuttycom
force-pushed
the
upgrade_halo2_patch_dependency
branch
from
16a143c to
a7c438e
Compare
Contributor
|
NACK, this included a revision from #381 that had not had comments addressed. |
str4d
reviewed
Mar 20, 2023
Comment on lines
+94
to
+95
| halo2_gadgets = { git = "https://github.com/zcash/halo2.git", rev = "642924d614305d882cc122739c59144109f4bd3f" } | ||
| halo2_proofs = { git = "https://github.com/zcash/halo2.git", rev = "642924d614305d882cc122739c59144109f4bd3f" } |
Contributor
There was a problem hiding this comment.
I confirmed this is the current tip of the main branch of zcash/halo2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to make use of the floor-planner-v1-legacy-pdqsort feature.