Add concrete error types for add_spend and add_output#366
Add concrete error types for add_spend and add_output#366nuttycom merged 8 commits intozcash:mainfrom zingolabs:add_concrete_errors_for_spend_and_output_construction
Conversation
|
|
zancas
left a comment
zancas
left a comment
There was a problem hiding this comment.
It seems to me that the changelog is out of sync with the actual mod paths, and that needs to be fixed.
Codecov ReportBase: 84.13% // Head: 84.15% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #366 +/- ##
==========================================
+ Coverage 84.13% 84.15% +0.02%
==========================================
Files 32 32
Lines 2672 2670 -2
==========================================
- Hits 2248 2247 -1
+ Misses 424 423 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
nuttycom
left a comment
nuttycom
left a comment
There was a problem hiding this comment.
Fixes required for the changelog, otherwise this LGTM.
This is an API-breaking change, so it will require a minor-version release.
CHANGELOG.md
Outdated
| - `orchard::builder`: | ||
| - `SpendError` | ||
| - `OutputsDisabled` | ||
|
|
||
| ### Changed | ||
| - Migrated to `zcash_note_encryption 0.2`. | ||
| - `orchard::builder::Builder::{add_spend, add_output}` now use | ||
| concrete error types instead of `&'static str`s. | ||
| - `orchard::builder::Error` is now `BuildError` to differentiate from |
There was a problem hiding this comment.
These should be in the Unreleased section.
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: str4d <thestr4d@gmail.com>
6 participants
No description provided.