Add spends/outputs getter fns to builders for use in change calculation#365
Merged
nuttycom merged 4 commits intozcash:mainfrom Jan 3, 2023
zingolabs:add_spends_and_outputs_getters_to_builder
Merged
Add spends/outputs getter fns to builders for use in change calculation#365nuttycom merged 4 commits intozcash:mainfrom zingolabs:add_spends_and_outputs_getters_to_builder
nuttycom merged 4 commits intozcash:mainfrom
zingolabs:add_spends_and_outputs_getters_to_builder
Conversation
Codecov ReportBase: 84.13% // Head: 83.86% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #365 +/- ##
==========================================
- Coverage 84.13% 83.86% -0.27%
==========================================
Files 32 32
Lines 2672 2678 +6
==========================================
- Hits 2248 2246 -2
- Misses 424 432 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
nuttycom
requested changes
Dec 7, 2022
Contributor
nuttycom
left a comment
nuttycom
left a comment
There was a problem hiding this comment.
The changelog needs fixing, otherwise LGTM
CHANGELOG.md
Outdated
Comment on lines
+24
to
+26
| - `orchard::builder`: | ||
| - `{SpendInfo::new, InputView, OutputView}` | ||
| - `Builder::{spends, outputs}` |
Contributor
There was a problem hiding this comment.
This should be moved to the Unreleased section.
nuttycom
reviewed
Dec 8, 2022
Co-authored-by: Kris Nuttycombe <kris@nutty.land>
nuttycom
reviewed
Jan 3, 2023
Co-authored-by: Kris Nuttycombe <kris@nutty.land>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Input/OutputViewtraits are nearly straight-copied from https://github.com/zcash/librustzcash/blob/main/zcash_primitives/src/transaction/components/sapling/fees.rs, I'm assuming that interface is the desired one to this kind of functionality.