Correct the doc comment and add a test for Builder::value_balance#359
Merged
nuttycom merged 2 commits intozcash:mainfrom Oct 10, 2022
Merged
Correct the doc comment and add a test for Builder::value_balance#359nuttycom merged 2 commits intozcash:mainfrom
Builder::value_balance#359nuttycom merged 2 commits intozcash:mainfrom
Conversation
daira
changed the title
Builder::value_balance added in #352Builder::value_balance
daira
changed the title
Builder::value_balanceBuilder::value_balance
daira
changed the title
Builder::value_balanceBuilder::value_balance
Codecov ReportBase: 88.61% // Head: 88.61% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #359 +/- ##
=======================================
Coverage 88.61% 88.61%
=======================================
Files 38 38
Lines 3875 3875
=======================================
Hits 3434 3434
Misses 441 441
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
… in zcash#352. Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
daira
force-pushed
the
add-value-balance-to-builder-docfix
branch
from
e550278 to
6458e27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #352.