book: Update commitment tree section with the design decision#18
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #18 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 3 3
Lines 18 18
=====================================
Misses 18 18 Continue to review full report at Codecov.
|
dconnolly
reviewed
Feb 27, 2021
Comment on lines
+68
to
+70
| We decided that this was too large a change from Sapling, and that it should be possible | ||
| to improve the Incremental Merkle Tree implementation to work around the efficiency issues | ||
| without domain-separating the tree. |
dconnolly
reviewed
Feb 27, 2021
Comment on lines
+11
to
+13
| The only difference is that we instantiate $\mathsf{MerkleCRH}^\mathsf{Orchard}$ with | ||
| Sinsemilla (whereas $\mathsf{MerkleCRH}^\mathsf{Sapling}$ used a Bowe--Hopwood Pedersen | ||
| hash). |
dconnolly
reviewed
Feb 27, 2021
Comment on lines
+3
to
+9
| The commitment tree structure for Orchard is identical to Sapling: | ||
|
|
||
| Orchard addresses this by splitting the commitment tree into several sub-trees: | ||
| - A single global commitment tree of fixed depth 32. | ||
| - Note commitments are appended to the tree in-order from the block. | ||
| - Valid Orchard anchors correspond to the global tree state at block boundaries (after all | ||
| commitments from a block have been appended, and before any commitments from the next | ||
| block have been appended). |
dconnolly
approved these changes
Feb 27, 2021
Contributor
|
"You didn't ask for my review but here you go!" (´・ω・)っ由 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 3 3
Lines 18 18
=====================================
Misses 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ebfull
pushed a commit
that referenced
this pull request
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.