Upgrade dependencies#94
Merged
Merged
Conversation
dconnolly
reviewed
Aug 5, 2019
There was a problem hiding this comment.
Everything else LGTM but I'm curious what prompted this change?
There was a problem hiding this comment.
Also there is no longer an assert, that's fine yes?
Contributor
Author
There was a problem hiding this comment.
And yes, there's no longer an assert because ChaCha20Ietf::xor mutates in-place and doesn't return anything.
dconnolly
reviewed
Aug 5, 2019
There was a problem hiding this comment.
I'm assuming the 3rd argument is the signifier of which block to start from instead of prefixing with a 'block' of zero bytes?
Contributor
Author
There was a problem hiding this comment.
Correct. See RFC 7539 section 2.8 for details.
Collaborator
|
LGTM, will re-review once #92 is merged. |
Contributor
Author
|
Rebased on master to fix merge conflicts after #92 was merged. |
ebfull
approved these changes
Aug 14, 2019
greg0x
pushed a commit
to valargroup/librustzcash
that referenced
this pull request
Mar 12, 2026
Move ceremony messages from custom wire format to standard Cosmos SDK tx signing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.