Conversation
This is more generally useful for debugging purposes than the default `Debug` impl for `&[u8]`. We also provide an alternate `Debug` impl for `legacy::Script` that parses and renders known opcodes. Note that we only parse a subset of the full opcode set.
This enhances the alternate `impl Debug for Script` to render unexpected scripts correctly.
Codecov ReportPatch coverage is 📢 Thoughts on this report? Let us know!. |
ebfull
approved these changes
Sep 1, 2023
Collaborator
|
Might want to list it as a change in the changelog on the crate since adding variants to public enums is not backwards compatible. Can be done in another PR or during the release though. |
Contributor
Author
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.