Skip to content

Update zcash_primitives to use zcash_note_encryption 0.3.0#790

Merged
nuttycom merged 1 commit into
mainfrom
sapling/zcash_note_encryption-0.3.0
Mar 21, 2023
Merged

Update zcash_primitives to use zcash_note_encryption 0.3.0#790
nuttycom merged 1 commit into
mainfrom
sapling/zcash_note_encryption-0.3.0

Conversation

@nuttycom
Copy link
Copy Markdown
Collaborator

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 10, 2023

Codecov Report

Patch coverage: 85.71% and project coverage change: -0.01 ⚠️

Comparison is base (847c187) 72.36% compared to head (9c4abf7) 72.35%.

❗ Current head 9c4abf7 differs from pull request most recent head d6fafa2. Consider uploading reports for the commit d6fafa2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #790      +/-   ##
==========================================
- Coverage   72.36%   72.35%   -0.01%     
==========================================
  Files         123      123              
  Lines       11838    11838              
==========================================
- Hits         8566     8565       -1     
- Misses       3272     3273       +1     
Impacted Files Coverage Δ
zcash_client_backend/src/welding_rig.rs 48.57% <ø> (ø)
zcash_client_sqlite/src/lib.rs 52.44% <ø> (ø)
components/zcash_note_encryption/src/lib.rs 88.74% <50.00%> (ø)
zcash_primitives/src/sapling/note_encryption.rs 95.03% <100.00%> (ø)
...ives/src/transaction/components/sapling/builder.rs 74.16% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nuttycom nuttycom force-pushed the sapling/zcash_note_encryption-0.3.0 branch from bae842f to 9c4abf7 Compare March 10, 2023 15:37
@nuttycom nuttycom force-pushed the sapling/zcash_note_encryption-0.3.0 branch from 9c4abf7 to 3d7cb11 Compare March 18, 2023 04:31
@nuttycom nuttycom force-pushed the release-zcash_note_encryption-0.3.0 branch from 300ba63 to 652a4c8 Compare March 18, 2023 04:34
@nuttycom nuttycom force-pushed the sapling/zcash_note_encryption-0.3.0 branch 5 times, most recently from ebe3c65 to e0f55e1 Compare March 20, 2023 22:20
@nuttycom nuttycom force-pushed the sapling/zcash_note_encryption-0.3.0 branch from e0f55e1 to d6fafa2 Compare March 21, 2023 17:09
@nuttycom nuttycom changed the base branch from release-zcash_note_encryption-0.3.0 to main March 21, 2023 17:19
Copy link
Copy Markdown
Collaborator

@ebfull ebfull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@nuttycom nuttycom merged commit ca349b6 into main Mar 21, 2023
@nuttycom nuttycom deleted the sapling/zcash_note_encryption-0.3.0 branch March 21, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants