Skip to content

Correctly construct outputs when spending internal notes.#688

Merged
str4d merged 4 commits into
zcash:mainfrom
nuttycom:wallet/spend_internal_notes
Nov 4, 2022
Merged

Correctly construct outputs when spending internal notes.#688
str4d merged 4 commits into
zcash:mainfrom
nuttycom:wallet/spend_internal_notes

Conversation

@nuttycom
Copy link
Copy Markdown
Collaborator

This builds atop #658

@nuttycom nuttycom requested review from pacu and str4d October 31, 2022 21:49
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 31, 2022

Codecov Report

Base: 72.57% // Head: 74.15% // Increases project coverage by +1.58% 🎉

Coverage data is based on head (5aa9f8f) compared to base (d4f4f5a).
Patch coverage: 95.34% of modified lines in pull request are covered.

❗ Current head 5aa9f8f differs from pull request most recent head 981d45e. Consider uploading reports for the commit 981d45e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #688      +/-   ##
==========================================
+ Coverage   72.57%   74.15%   +1.58%     
==========================================
  Files         107      106       -1     
  Lines       10926    10306     -620     
==========================================
- Hits         7929     7642     -287     
+ Misses       2997     2664     -333     
Impacted Files Coverage Δ
zcash_client_backend/src/address.rs 86.40% <ø> (ø)
zcash_client_backend/src/data_api/error.rs 16.00% <0.00%> (-0.33%) ⬇️
zcash_client_backend/src/encoding.rs 36.79% <ø> (ø)
zcash_client_sqlite/src/wallet/init.rs 70.90% <ø> (ø)
zcash_client_sqlite/src/wallet/transact.rs 76.74% <ø> (ø)
zcash_extensions/src/transparent/demo.rs 76.62% <ø> (ø)
zcash_primitives/src/merkle_tree.rs 93.28% <ø> (+0.42%) ⬆️
zcash_primitives/src/transaction/builder.rs 81.81% <ø> (ø)
zcash_client_backend/src/data_api/wallet.rs 53.84% <92.30%> (+0.98%) ⬆️
zcash_client_backend/src/keys.rs 88.55% <100.00%> (ø)
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed f3f31dab1cea2a3490e02001c5461737f52095f1.

Comment thread zcash_client_backend/src/welding_rig.rs Outdated
Comment thread zcash_primitives/src/zip32/sapling.rs Outdated
Comment thread zcash_client_backend/src/data_api/wallet.rs Outdated
@nuttycom nuttycom force-pushed the wallet/spend_internal_notes branch 3 times, most recently from a6bfa33 to 0b1fb44 Compare November 2, 2022 15:45
@nuttycom nuttycom marked this pull request as ready for review November 2, 2022 15:46
@nuttycom nuttycom force-pushed the wallet/spend_internal_notes branch from 0b1fb44 to d6aca79 Compare November 2, 2022 16:35
Copy link
Copy Markdown
Collaborator

@pacu pacu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Comment thread zcash_primitives/CHANGELOG.md Outdated
@nuttycom nuttycom force-pushed the wallet/spend_internal_notes branch 2 times, most recently from 345a92d to b7f6735 Compare November 3, 2022 21:14
@nuttycom nuttycom force-pushed the wallet/spend_internal_notes branch from b7f6735 to cdfca84 Compare November 4, 2022 00:44
Comment thread zcash_primitives/src/sapling.rs
Copy link
Copy Markdown
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK cdfca84 after changelog updates.

Comment thread zcash_primitives/src/zip32/sapling.rs
Comment thread zcash_primitives/src/zip32/sapling.rs
Copy link
Copy Markdown
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-utACK 981d45e. Changes over last review are only to documentation.

@str4d str4d merged commit c5d8484 into zcash:main Nov 4, 2022
@nuttycom nuttycom deleted the wallet/spend_internal_notes branch November 4, 2022 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants