Skip to content

Pre-0.3.0 changes#281

Merged
str4d merged 4 commits into
zcash:masterfrom
str4d:pre-0.3.0-changes
Aug 23, 2020
Merged

Pre-0.3.0 changes#281
str4d merged 4 commits into
zcash:masterfrom
str4d:pre-0.3.0-changes

Conversation

@str4d
Copy link
Copy Markdown
Contributor

@str4d str4d commented Aug 23, 2020

  • Fix an intra-doc link.
  • Add feature flags to docs.rs documentation.

@str4d str4d mentioned this pull request Aug 23, 2020
@str4d str4d force-pushed the pre-0.3.0-changes branch from 52e7fb9 to cda56ef Compare August 23, 2020 11:12
@str4d
Copy link
Copy Markdown
Contributor Author

str4d commented Aug 23, 2020

You can test this PR locally with:

RUSTDOCFLAGS="--cfg docsrs" cargo +nightly doc --all-features

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 23, 2020

Codecov Report

Merging #281 into master will increase coverage by 0.00%.
The diff coverage is 84.91%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #281   +/-   ##
=======================================
  Coverage   66.02%   66.03%           
=======================================
  Files         101      101           
  Lines       13214    13215    +1     
=======================================
+ Hits         8725     8726    +1     
  Misses       4489     4489           
Impacted Files Coverage Δ
bls12_381/src/g1.rs 71.52% <ø> (ø)
bls12_381/src/g2.rs 69.04% <ø> (ø)
bls12_381/src/pairings.rs 58.67% <ø> (ø)
jubjub/src/lib.rs 56.62% <ø> (ø)
zcash_primitives/src/note_encryption.rs 77.29% <ø> (+0.06%) ⬆️
zcash_primitives/src/prover.rs 30.76% <ø> (ø)
...imitives/src/test_vectors/pedersen_hash_vectors.rs 100.00% <ø> (ø)
zcash_primitives/src/transaction/components.rs 35.21% <ø> (ø)
zcash_proofs/src/lib.rs 69.69% <ø> (ø)
zcash_proofs/src/prover.rs 65.85% <ø> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b6c814...cda56ef. Read the comment docs.

Copy link
Copy Markdown
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@str4d str4d merged commit 9bfb935 into zcash:master Aug 23, 2020
@str4d str4d deleted the pre-0.3.0-changes branch August 23, 2020 14:30
@daira
Copy link
Copy Markdown
Contributor

daira commented Aug 23, 2020

Tested ACK.

@r3ld3v r3ld3v added this to the Core Sprint 2020-33 milestone Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants