pczt: Add public getter for shielded sighash#2282
Closed
p0mvn wants to merge 1 commit into
Closed
Conversation
nuttycom
force-pushed
the
roman/pczt-0.5.x/shielded-sighash-pub
branch
from
8bc4f72 to
16cac0a
Compare
Backports the `Signer::shielded_sighash` accessor from main (added in zcash#2047) to the 0.5.x series, enabling downstream consumers to obtain the sighash for producing signatures externally (e.g. via a hardware wallet). Made-with: Cursor
nuttycom
force-pushed
the
roman/pczt-0.5.x/shielded-sighash-pub
branch
from
16cac0a to
a65f752
Compare
nuttycom
approved these changes
Apr 23, 2026
Collaborator
|
Duplicate of #2047 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on
maint/pczt-0.5.x(branched frompczt-0.5.0series). This is aSemVer-compatible addition intended for a
0.5.xpoint release.Backports the
Signer::shielded_sighashaccessor from main (added in #2047) to the 0.5.x series, enabling downstream consumers to obtain the sighash for producing signatures externally (e.g. via a hardware wallet).How We Use It
Token Holder Voting.
We use
shielded_sighash()to extract the ZIP-244 transaction digest from the finalized PCZT so that both signing paths (software key derivation and Keystone hardware) produce a spend-auth signature over the same canonical hash.See full summary of the integration: https://hackmd.io/@TJGUVkqNQYieiMqJQQBDeA/rJ0mU1v3Wl