Skip to content

pczt: Add public getter for spend_auth_sig#2281

Merged
nuttycom merged 1 commit into
zcash:mainfrom
valargroup:roman/pczt-0.5.x/pub-spend_auth_sig
Apr 23, 2026
Merged

pczt: Add public getter for spend_auth_sig#2281
nuttycom merged 1 commit into
zcash:mainfrom
valargroup:roman/pczt-0.5.x/pub-spend_auth_sig

Conversation

@p0mvn
Copy link
Copy Markdown
Collaborator

@p0mvn p0mvn commented Apr 11, 2026

Based on maint/pczt-0.5.x (branched from pczt-0.5.0 series). This is a
SemVer-compatible addition intended for a 0.5.x point release.

Expose the Orchard spend authorization signature via getset, enabling downstream consumers to read back the signature after signing

How We Use It

Token Holder Voting.

We use spend_auth_sig() as a read-only accessor to extract the 64-byte spend authorization signature from a Keystone-signed PCZT, so it can be forwarded to the cosmos chain as part of the delegation transaction.

See full summary of the integration: https://hackmd.io/@TJGUVkqNQYieiMqJQQBDeA/rJ0mU1v3Wl

@p0mvn p0mvn marked this pull request as ready for review April 11, 2026 17:55
nuttycom
nuttycom previously approved these changes Apr 13, 2026
Copy link
Copy Markdown
Collaborator

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 2f6769b

@nuttycom
Copy link
Copy Markdown
Collaborator

CI is broken here because of the core2 yank. Given that we have to release the whole stack anyway, I'm going to rebase and retarget this to main.

@nuttycom nuttycom changed the base branch from maint/pczt-0.5.x to main April 23, 2026 02:31
@nuttycom nuttycom dismissed their stale review April 23, 2026 02:31

The base branch was changed.

@nuttycom
Copy link
Copy Markdown
Collaborator

@p0mvn oh, I just realized I can't push to the valargroup branches, so you'll have to do the rebase.

Expose the Orchard spend authorization signature via `getset`, enabling
downstream consumers to read back the signature after signing (e.g. for
extracting the signature from a hardware-wallet-signed PCZT and
forwarding it to the chain).

Made-with: Cursor
@p0mvn p0mvn force-pushed the roman/pczt-0.5.x/pub-spend_auth_sig branch from 2f6769b to 3c3ecdf Compare April 23, 2026 03:54
@p0mvn p0mvn requested a review from nuttycom April 23, 2026 03:55
@p0mvn
Copy link
Copy Markdown
Collaborator Author

p0mvn commented Apr 23, 2026

@nuttycom rebase completed. Also, granted access to the valargroup fork.

@ValarDragon
Copy link
Copy Markdown
Collaborator

Thank you!!

Copy link
Copy Markdown
Collaborator

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants