zcash_client_sqlite: Enable WalletWrite calls in WalletDb::transactionally#2253
Merged
Conversation
nuttycom
previously approved these changes
Mar 30, 2026
Collaborator
nuttycom
left a comment
nuttycom
left a comment
There was a problem hiding this comment.
utACK 0535d18 modulo clippy fixes.
It might make sense for truncate_to_height_internal to take a SqlTransaction instead of a rusqlite::Transaction; I think that with that change the internals of SqlTransaction might be able to be entirely private instead of crate-private?
…tionally` This enables amortizing the database transaction overhead, which gives a significant performance boost to repeated operations. For example, in Zallet this reduces the time to make 200 `WalletWrite::store_decrypted_tx` calls from 28s to 11s on my development machine.
Contributor
Author
|
Force-pushed to fix clippy lint. |
nuttycom
previously approved these changes
Mar 30, 2026
Apparently we weren't relying on accessing them outside this module, and this is better for ensuring it is used correctly.
nuttycom
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables amortizing the database transaction overhead, which gives a significant performance boost to repeated operations. For example, in Zallet this reduces the time to make 200
WalletWrite::store_decrypted_txcalls from 28s to 11s on my development machine.