Remove ff::PrimeFieldRepr#223
Merged
Merged
Conversation
Adapted from Scalar::non_adjacent_form in curve25519-dalek.
The trait is implemented by default for u8 and u64, allowing pow_vartime to be used with both the byte encoding and limb representation of field elements.
This enables BitIterator to be used with both the byte encoding and limb representation of scalars.
str4d
added
the
S-scratching-an-itch
The ff::PrimeField::Repr associated type now has the minimal necessary bounds, which can be satisfied by a newtype around a byte array.
str4d
force-pushed
the
remove-primefieldrepr
branch
from
1c2b203 to
49f119f
Compare
Codecov Report
@@ Coverage Diff @@
## master #223 +/- ##
===========================================
+ Coverage 51.08% 65.34% +14.25%
===========================================
Files 99 106 +7
Lines 13318 15041 +1723
===========================================
+ Hits 6804 9828 +3024
+ Misses 6514 5213 -1301
Continue to review full report at Codecov.
|
This was referenced Apr 24, 2020
Collaborator
|
ACK though there's some more API fiddling I'd like to do, we can do it later. |
greg0x
pushed a commit
to valargroup/librustzcash
that referenced
this pull request
Mar 12, 2026
Cache share_reveal params/keys with OnceLock and unify proving_key API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #159.