Add binding signature only if needed#221
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #221 +/- ##
==========================================
+ Coverage 51.08% 51.30% +0.21%
==========================================
Files 99 99
Lines 13318 13350 +32
==========================================
+ Hits 6804 6849 +45
+ Misses 6514 6501 -13
Continue to review full report at Codecov.
|
daira
previously requested changes
Apr 4, 2020
daira
left a comment
daira
left a comment
Contributor
There was a problem hiding this comment.
Needs a test that would have failed without this change. Otherwise utACK.
Contributor
Author
|
Added 2 tests. |
greg0x
pushed a commit
to valargroup/librustzcash
that referenced
this pull request
Mar 12, 2026
Add server heartbeat system for helper liveness tracking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #220 .