Skip to content

fix: Fix github-pages build#2103

Merged
nuttycom merged 1 commit into
zcash:mainfrom
nullcopy:fix/2101-ghpages-build-failure
Jan 21, 2026
Merged

fix: Fix github-pages build#2103
nuttycom merged 1 commit into
zcash:mainfrom
nullcopy:fix/2101-ghpages-build-failure

Conversation

@nullcopy
Copy link
Copy Markdown
Contributor

cargo-doc was failing due to doc references to modules behind feature gates. This commit enables all features when building docs for the gitbook.

Resolves #2101

@nullcopy nullcopy requested a review from str4d January 20, 2026 22:13
@nullcopy nullcopy marked this pull request as draft January 20, 2026 22:26
@nullcopy nullcopy removed the request for review from str4d January 20, 2026 23:48
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.83%. Comparing base (98ab759) to head (83ef1db).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2103   +/-   ##
=======================================
  Coverage   73.83%   73.83%           
=======================================
  Files         222      222           
  Lines       36716    36716           
=======================================
  Hits        27108    27108           
  Misses       9608     9608           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nullcopy nullcopy closed this Jan 21, 2026
@nullcopy nullcopy force-pushed the fix/2101-ghpages-build-failure branch from 7ae12fe to 0a75d32 Compare January 21, 2026 16:58
@nullcopy nullcopy reopened this Jan 21, 2026
@nullcopy nullcopy marked this pull request as ready for review January 21, 2026 17:10
Copy link
Copy Markdown
Collaborator

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@nuttycom
Copy link
Copy Markdown
Collaborator

Looks like this might need to be rebased after the merge of the cargo vet fix.

@nuttycom nuttycom enabled auto-merge January 21, 2026 18:28
cargo-doc was failing due to doc references to modules behind feature
gates. This commit enables all features when building docs for the
gitbook.
@nullcopy nullcopy force-pushed the fix/2101-ghpages-build-failure branch from 7ae12fe to 83ef1db Compare January 21, 2026 18:32
@nuttycom nuttycom merged commit 7ec5430 into zcash:main Jan 21, 2026
46 checks passed
@nullcopy nullcopy deleted the fix/2101-ghpages-build-failure branch January 21, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: cargo-doc does not build

2 participants