[ZIP-233] Network Sustainability Mechanism: Burning

[nuttycom]

This builds atop #1567 to bring it up to date with the current state of main and address comments from code review.

[nuttycom]

utACK 304c71b - this is left as a comment because I opened this PR to subsume #1567

[nuttycom]

re-utACK d47531c with lint fixes.

[daira]

It looks like the build is failing in CI. I will wait until that's fixed to review.

[arya2]

This is looking good. I still need to review the test data.

[arya2]

It would be nice to export transaction::tests::data from lib directly instead of adding everything in transaction::tests into compilations with the test-dependencies feature enabled and hiding most of it individually.

[nuttycom]

utACK 3c946e7

[daira]

One blocking comment, otherwise utACK.

[codecov]

Codecov Report

❌ Patch coverage is 20.18349% with 87 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.61%. Comparing base (9dcd4a9) to head (f3045af).
⚠️ Report is 23 commits behind head on main.

Files with missing lines	Patch %	Lines
zcash_primitives/src/transaction/mod.rs	11.11%	64 Missing ⚠️
zcash_primitives/src/transaction/builder.rs	11.11%	8 Missing ⚠️
pczt/src/roles/tx_extractor/mod.rs	0.00%	4 Missing ⚠️
zcash_client_sqlite/src/wallet.rs	0.00%	4 Missing ⚠️
components/zcash_protocol/src/value.rs	0.00%	2 Missing ⚠️
...h_primitives/src/transaction/components/orchard.rs	0.00%	2 Missing ⚠️
zcash_primitives/src/transaction/sighash.rs	0.00%	2 Missing ⚠️
zcash_primitives/src/transaction/sighash_v6.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1879      +/-   ##
==========================================
- Coverage   57.79%   57.61%   -0.18%     
==========================================
  Files         184      185       +1     
  Lines       22386    22478      +92     
==========================================
+ Hits        12938    12951      +13     
- Misses       9448     9527      +79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[daira]

re-utACK

[daira]

utACK

[aphelionz]

Whooo!!! 🥳