Skip to content

Fix clippy complaints.#1785

Merged
str4d merged 1 commit into
mainfrom
clippy_fix
Apr 30, 2025
Merged

Fix clippy complaints.#1785
str4d merged 1 commit into
mainfrom
clippy_fix

Conversation

@nuttycom
Copy link
Copy Markdown
Collaborator

No description provided.

@nuttycom nuttycom force-pushed the clippy_fix branch 2 times, most recently from 7c3c53c to aec940b Compare April 30, 2025 15:52
Comment thread .github/workflows/ci.yml Fixed
Comment thread .github/workflows/ci.yml Fixed
Copy link
Copy Markdown
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 482f5aa.

Comment thread zcash_client_sqlite/src/wallet/init.rs
Comment thread zcash_client_sqlite/src/wallet/init.rs
Copy link
Copy Markdown
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK c95b926

@str4d str4d merged commit 3b04f2f into main Apr 30, 2025
43 checks passed
@str4d str4d deleted the clippy_fix branch April 30, 2025 17:47
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 58.01%. Comparing base (0d388d8) to head (c95b926).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
zcash_client_sqlite/src/wallet/init.rs 0.00% 6 Missing ⚠️
zcash_proofs/src/downloadreader.rs 0.00% 2 Missing ⚠️
zcash_proofs/src/lib.rs 0.00% 2 Missing ⚠️
zcash_client_backend/src/tor/http.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1785      +/-   ##
==========================================
- Coverage   58.01%   58.01%   -0.01%     
==========================================
  Files         181      181              
  Lines       21976    21977       +1     
==========================================
  Hits        12750    12750              
- Misses       9226     9227       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-hoc ACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants