zcash_client_backend: Generalize & extend wallet metadata query API#1580
Merged
nuttycom merged 2 commits intoNov 13, 2024
Merged
Conversation
nuttycom
force-pushed
the
wallet/multi_output_dynamic_min_split
branch
3 times, most recently
from
98093e1 to
9ca4f50
Compare
nuttycom
force-pushed
the
wallet/multi_output_dynamic_min_split
branch
2 times, most recently
from
cb12eb7 to
3fe1cdb
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
nuttycom
force-pushed
the
wallet/multi_output_dynamic_min_split
branch
2 times, most recently
from
37f993e to
600b5e6
Compare
nuttycom
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1580 +/- ##
==========================================
+ Coverage 56.30% 56.38% +0.07%
==========================================
Files 148 148
Lines 19062 19232 +170
==========================================
+ Hits 10733 10844 +111
- Misses 8329 8388 +59 ☔ View full report in Codecov by Sentry. |
nuttycom
force-pushed
the
wallet/multi_output_dynamic_min_split
branch
3 times, most recently
from
e9ad4a6 to
530d06b
Compare
str4d
requested changes
Nov 13, 2024
nuttycom
force-pushed
the
wallet/multi_output_dynamic_min_split
branch
from
530d06b to
8c95260
Compare
This generalizes the previous account metadata query API to be able to represent more complex queries, and also to return note totals in addition to note counts.
nuttycom
force-pushed
the
wallet/multi_output_dynamic_min_split
branch
from
7dab03a to
3352671
Compare
Collaborator
Author
|
force-pushed to address comments from code review. |
str4d
previously approved these changes
Nov 13, 2024
daira
reviewed
Nov 13, 2024
daira
reviewed
Nov 13, 2024
nuttycom
force-pushed
the
wallet/multi_output_dynamic_min_split
branch
from
b87558f to
01b0d1c
Compare
Co-authored by: Jack Grig <jack@electriccoin.co> Co-authored-by: Daira-Emma Hopwood <daira@jacaranda.org>
nuttycom
force-pushed
the
wallet/multi_output_dynamic_min_split
branch
from
01b0d1c to
00cafa3
Compare
str4d
approved these changes
Nov 13, 2024
daira
reviewed
Nov 24, 2024
| { | ||
| // Creates a transaction that sends the specified value from the given account to | ||
| // the provided recipient address, using a greedy input selector and the default | ||
| // mutli-output change strategy. |
daira
reviewed
Nov 24, 2024
|
|
||
| // Spend half of each one of our notes, so that we can get a distribution of sent note values. | ||
| // FIXME: This test is currently excessively specialized to the `zcash_client_sqlite::WalletDb` | ||
| // implmentation of the `InputSource` trait. A better approach would be to create a test input |
daira
reviewed
Nov 24, 2024
Contributor
daira
left a comment
daira
left a comment
There was a problem hiding this comment.
Post-hoc ACK. There are a couple of typos in comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.