Specify rand_core >= 0.5.1 for OsRng import.#137
Merged
Conversation
str4d
approved these changes
Oct 4, 2019
Contributor
str4d
left a comment
str4d
left a comment
There was a problem hiding this comment.
ACK; good catch. This wasn't caught by CI because we were already pinning to rand_core 0.5.1 in Cargo.lock, but this is clearly correct and necessary for correct behaviour in downstream consumers of our crates.
jimpo
force-pushed
the
rand_core-version
branch
from
0dc6c32 to
13c0764
Compare
jimpo
force-pushed
the
rand_core-version
branch
from
13c0764 to
93563c3
Compare
str4d
approved these changes
Oct 5, 2019
greg0x
pushed a commit
to valargroup/librustzcash
that referenced
this pull request
Mar 12, 2026
- Add sentinel injection (k*2^250 for k=0..16) to pir-export to satisfy circuit gap-width constraint (#3) - Change Tier 2 empty-leaf padding from Fp::zero() to -Fp::one() so trailing entries sort after real leaves, fixing binary search (#2) - Make TierServer::answer_query() return Result with input validation (length checks, alignment) instead of panicking on malformed requests; handlers return HTTP 400 on error (#1) - Replace unwrap/assert with fallible returns in pir-client and Tier0Data::from_bytes (#4)
greg0x
pushed a commit
to valargroup/librustzcash
that referenced
this pull request
Mar 12, 2026
- Tier 2 extract_siblings: detect padding leaves (key=p-1, value=0) and use hash(0,0) to match empty_hashes[0] from tree construction - PIR server answer_query: compute payload_len once to avoid overflow on attacker-controlled pqr_byte_len - PIR client connect: validate root29 hex decodes to exactly 32 bytes before copy_from_slice
greg0x
pushed a commit
to valargroup/librustzcash
that referenced
this pull request
Mar 12, 2026
Add PIR-based private nullifier queries using YPIR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue introduced by #134.
rand_core0.5.0 does not exportOsRngin the crate root but 0.5.1 does.@NikVolf