Feature: Add an in-memory wallet backend framework#1293
Closed
nuttycom wants to merge 26 commits into
Closed
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1293 +/- ##
==========================================
- Coverage 63.23% 63.09% -0.15%
==========================================
Files 124 122 -2
Lines 14507 14058 -449
==========================================
- Hits 9174 8870 -304
+ Misses 5333 5188 -145 ☔ View full report in Codecov by Sentry. |
Fix the memory wallet build by hiding orchard fields in `new()` behind a flag
Co-authored-by: Kris Nuttycombe <kris@nutty.land>
Basic `put_block` function for the memory wallet
Contributor
|
I think it can be a good to create a list of the minimal requirements we consider needed to merge this PR while leave the rest of the functions to make individual pull requests against the main repo ? |
Contributor
Collaborator
Author
|
Supplanted by #1923 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets up the general framework; most of the implementation is
todo!().Closes #1414.