Add zerovec ULE impls for TinyStr #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
reviewed
May 11, 2021
|
|
||
| // This converts between endiannesses twice: TinyStr::new_unchecked() | ||
| // takes in a native endian integer, which we produce via from_unaligned() | ||
| Self::new_unchecked(<$integer>::from_unaligned(&unaligned.0)) |
There was a problem hiding this comment.
Suggestion: Create a const unsafe constructor for TinyStr (in the normal library code) that takes a &[u8; $size]; it can use <$integer>::from_ne_bytes() in its impl. Then here, pass in the bytes.
There was a problem hiding this comment.
I'd rather do this when we figure out the overall endianness story.
sffc
approved these changes
May 11, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on unicode-org/icu4x#652 , fixes #41