Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add const generic ENABLE_SANITY_CHECK to control sanity check part in NIMFS prove #15

Merged
merged 3 commits into from
Jun 8, 2024
Merged

add const generic ENABLE_SANITY_CHECK to control sanity check part in NIMFS prove #15

merged 3 commits into from
Jun 8, 2024

Conversation

CoolwindHF
Copy link
Collaborator

@CoolwindHF CoolwindHF commented Jun 7, 2024 •
edited by RequiemOfSoul
Loading

closes #12

@RequiemOfSoul
Copy link
Collaborator

  1. The Primary and secondary circuit satisfiability checks are added to the sanity check.
  2. The nimfs.v and nifs.v are also added to the sanity check.
  3. Remove all check_relation call(the PCDNode.verify function already contains)

@RequiemOfSoul RequiemOfSoul merged commit 3c239d2 into main Jun 8, 2024
1 check passed
@RequiemOfSoul RequiemOfSoul deleted the add-sanity-check-control branch June 11, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RequiemOfSoul RequiemOfSoul RequiemOfSoul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add const generic for sanity check
2 participants
@CoolwindHF @RequiemOfSoul