Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: pre-release cleanup #162

Merged
merged 10 commits into from
Jan 31, 2024
Merged

refactor: pre-release cleanup #162

merged 10 commits into from
Jan 31, 2024

Conversation

balajtimate
Copy link
Collaborator

Description

  • Remove cluster_tests directory, update .gitignore, remove mined_test_data.tsv (include them in separate repo)
  • Update README with correct order of results inference, update cli test
  • Minor refactor of get_lib_type.py to fix _update_relationship_type()
  • Update tests

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Checklist

Please carefully read these items and tick them off if the statements are true
or do not apply.

  • I have performed a self-review of my own code
  • My code follows the existing coding style, lints and generates no new
    warnings
  • I have added type annotations to all function/method signatures, and I
    have added type annotations for any local variables that are non-trivial,
    potentially ambiguous or might otherwise benefit from explicit typing.
  • I have commented my code in hard-to-understand areas
  • I have added ["Google-style docstrings"] to all new modules, classes,
    methods/functions or updated previously existing ones
  • I have added tests that prove my fix is effective or that my feature
    works
  • New and existing unit tests pass locally with my changes and I have not
    reduced the code coverage relative to the previous state
  • I have updated any sections of the app's documentation that are affected
    by the proposed changes

If for some reason you are unable to tick off all boxes, please leave a
comment explaining the issue you are facing so that we can work on it
together.

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (69ea74c) 100.00% compared to head (3ad8d6a) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev      #162   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines         1143      1143           
=========================================
  Hits          1143      1143           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uniqueg uniqueg changed the title refactor: remove cluster tests dir, update get_lib_type refactor: pre-release cleanup Jan 31, 2024
@uniqueg uniqueg merged commit e100d72 into dev Jan 31, 2024
19 checks passed
@uniqueg uniqueg deleted the remove_cluster_test branch January 31, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants