This repository has been archived by the owner on Mar 29, 2024. It is now read-only.
fix(lease): should not panic on keep_alive #85
Merged
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in
LeaseKeepAlive
, calling thekeep_alive
function may cause a panic if a send operation is performed onreq_tx
.There may be some network fluctuations due to poor network conditions in my usage environment (due to cross-border use). I have a keep-alive logic that calls
keep_alive_for
for retries during fluctuations, which caused this panic in actual scenarios.Therefore, when send fails, I use the same logic as keep_alive_for to return a channel close error.