New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise Webpush::Unauthorized on HTTP 403 #59

Merged

zaru merged 1 commit into zaru:master from pushpad:handle_403

Jan 9, 2019

Contributor

collimarco commented Jan 4, 2019

If you use the wrong VAPID key pair (from another sender), FCM returns 403 MismatchSenderId.

It makes sense to raise the same error for 401 and 403, since they are both related to VAPID.


          Raise Webpush::Unauthorized on HTTP 403

35651e9

zaru merged commit 8c52288 into zaru:master

Owner

zaru commented Jan 9, 2019

@collimarco Thanks for PR! It's merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet