Core protocol v3.0 - chunk memory layouts#24
Merged
alimanfoo merged 2 commits intozarr-developers:core-protocol-v3.0-devfrom May 21, 2019
Merged
Conversation
alimanfoo
force-pushed
the
core-protocol-v3.0-memory-layout
branch
from
639b98d to
0a7b70a
Compare
martindurant
reviewed
May 9, 2019
| For example, for a two-dimensional array with chunk shape (dx, dy), | ||
| the binary values for a given chunk are taken from chunk elements in | ||
| the order (0, 0), (0, 1), (0, 2), ..., (dx - 1, dy - 3), (dx - 1, dy - | ||
| 2), (dx - 1, dy - 1). |
Member
There was a problem hiding this comment.
Maybe worth mentioning here, that the memory offset/location within the chunk is determined by this ordering and the size of the dtype. Will endianness be in the dtype section only (I know it's mentioned already). That could be be loosely considered memory layout, especially for sub-byte types.
Member
Author
There was a problem hiding this comment.
Sounds good. Could you suggest an edit?
martindurant
reviewed
May 9, 2019
alimanfoo
changed the title
Member
Author
|
In the interests of having content together in one place, I'd like to merge this PR into the core-protocol-v3.0-dev branch. We can still discuss, revise and revisit anything after merge. I'll merge tomorrow if no objections. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds draft content for the core protocol v3.0 section on memory layouts.