Add CRC-32C checksum to sharded index format #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I also clarified the language a bit to account for the possibility of nested sharding. |
Contributor
Author
|
@normanz Your input would be much appreciated. |
Contributor
|
Worth combining this with a spec for a CRC-32C bytes->bytes codec to apply to chunks too? Seems like low-hanging fruit if we're pulling in that functionality anyway. I know this PR just deals with the chunk address footer, and they should stay separate as adding a checksum would break partial reads. |
Contributor
Author
|
I agree it makes sense to add a crc32c bytes->bytes codec, but I would just assume address that in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.