Skip to content

Restructure keys and remove entry-point metadata #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 9, 2023
Merged

Restructure keys and remove entry-point metadata #200

merged 4 commits into from
Feb 9, 2023

Conversation

@jbms
Copy link
Contributor

@jbms jbms commented Feb 2, 2023 •
edited by jstriebel
Loading

Fixes #192, fixes #177

@jbms jbms requested a review from jstriebel February 2, 2023 05:27
rabernat
rabernat previously approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@rabernat rabernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this and think it looks all good.

Thanks for taking the time to write this down Jeremey.

jstriebel
jstriebel previously approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@jstriebel jstriebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jbms! Also LGTM, just pushed a commit with minor formatting edits. I also started to clean-up the Storage – Operations section, but noticed that it's quite out of date and probably better fixed in a separate PR. (We might even consider removing it completly, I'm not quite sure how helpful it is.)

@jstriebel
Copy link
Member

@rabernat Could you approve this once again? my approval doesn't count since I commited and also my commit automatically discarded your previous one.

@jstriebel
Copy link
Member

jstriebel commented Feb 8, 2023 •
edited
Loading

PS: A changelog entry is missing, could you add one @jbms? done

@jstriebel jstriebel mentioned this pull request Feb 9, 2023
Closed
joshmoore
joshmoore approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joshmoore joshmoore merged commit 4536d19 into zarr-developers:main Feb 9, 2023
@rabernat rabernat mentioned this pull request Feb 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshmoore joshmoore joshmoore approved these changes

@rabernat rabernat rabernat left review comments

@jstriebel jstriebel jstriebel left review comments

Assignees

No one assigned

Labels

None yet

Projects

ZEP1
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Consider to remove entrypoint metadata, do not specify root v3 core spec: Consider to drop /meta prefix, have file at URI

4 participants

@jbms @jstriebel @joshmoore @rabernat