Skip to content

Conversation

@jstriebel
Copy link
Member

This is a POC for a draft watermark using the sphinxmark extension. Currently it's only possible to mark all pages or none, see kallimachos/sphinxmark#5. Might fix #170.

@jstriebel jstriebel requested a review from joshmoore November 24, 2022 18:06
@jstriebel jstriebel self-assigned this Nov 24, 2022
@jstriebel jstriebel marked this pull request as ready for review November 24, 2022 18:17
joshmoore
joshmoore previously approved these changes Nov 25, 2022
Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://zarr-specs--180.org.readthedocs.build/en/180/extensions/data-types/complex/v1.0.html

Screen Shot 2022-11-25 at 09 20 41

That's exceedingly clear. Open to opinions on if it makes reading difficult.

@jstriebel
Copy link
Member Author

jstriebel commented Nov 25, 2022

@joshmoore I saw that #168 also accidentally updated the theme. There were some nice additions, but some things also felt off (e.g. the content was too narrow on large screens IMO). You can see version after the update https://zarr-specs.readthedocs.io/en/latest/core/v3.0.html, and the version with the changes from this branch here. If the updated theme does not fit, we could also pin the previous version, which was 0.8.0.

I also used a more light-weight draft watermark now:
Screenshot from 2022-11-25 15-23-19

What do you think about the changes @joshmoore @MSanKeys963?

@sanketverma1704
Copy link
Member

Hi @jstriebel. Thanks for sending the PR.

I had a look at the current version and one in this PR. I prefer the one in this PR here. This one is less narrow and better utilises the spaces on the left and right-hand side of the screen. This may be a personal preference, and I'm happy to see what others think.

@joshmoore joshmoore merged commit 08d460a into zarr-developers:main Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Potentially add "Draft" watermark

3 participants